The patch looks ok. Plain mmap call shouldn't cause SIGBUS, it should return an error if the file can't be mapped.
I was going to say that we could move the sigsetjmp to before the loop even begins (just to be safe and save some cpu cycles), but it probably should stay where it is. Sigsetjmp man page states that the stack context is saved at the time of the call. That includes the buf- variable, which we cannot unmap if context is set before mmap. --RZ -- Crash when hashing files https://bugs.launchpad.net/bugs/473173 You received this bug notification because you are a member of LinuxDC++ Team, which is subscribed to LinuxDC++. Status in Linux DC++: Fix Committed Bug description: My linuxdcpp 1.0.3 crashes when hashing files from an external usb drive in a reiserfs partition. I attach the bugreport. The error is this: linuxdcpp: xcb_io.c:176: process_responses: La declaración `!(req && current_request && !(((long) (req->sequence) - (long) (current_request)) <= 0))' no se cumple. Multiple segmentation faults occurred; can't display error dialog I don't know why but sometimes restarting the program solves the error, but with some concrete files it always crashes! So I think it depens on the file. Thanks _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : [email protected] Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
