This is not fixed, i can still reproduce the bug.
** Changed in: adchpp
Status: Fix Committed => Confirmed
--
Unsent messages on disconnect
https://bugs.launchpad.net/bugs/491951
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to ADCH++.
Status in ADCH++: Confirmed
Bug description:
Somtimes when sending messages just before a disconnect the clients doesnt
recieve all messages. After doing some testing i found out that slower
handeling in ADCH++ made it harder to reproduce. My testing is based on the
attached files.
Brief description of what's happening in ManagedSocket:
Note: sock is the asio sock thingie...
ManagedSocket::write is called 4 times with commands to send.
ManagedSocket disc is set to 5000+GET_TICK() when all 4 commands have arrived.
(client.disconnect(0))
When the first command arrives, its added to the outBuff and
ManagedSocket::prepareWrite is called().
Then the outBuff is passed over to sock->write() and writing is set to True.
While writing the remaining (3) commands gets added to the outBuff stack.
ManagedSocket::completeWrite is called for the 1st command (without error),
this removes it from the outBuff stack, writing is set to False and calls
prepareWrite() again.
prepareWrite() passes the remaining 3 commands in the outBuff to sock->write() .
ManagedSocket::completeWrite is called (without error), all data is reported as
beeing sent.
writing is set to False, and prepareWrite() is called.
In prepareWrite, the fucn discovers that ( disc > 0) and outBuf.empty() then
sock->close() is called.
It appears to me as the data has been sent, but still some times it doesn't get
recieved in the client.
Providing config and scriptfiles for testing (thanks poy).
Tested on windows, not sure if this happens on linux.
_______________________________________________
Mailing list: https://launchpad.net/~linuxdcpp-team
Post to : linuxdcpp-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~linuxdcpp-team
More help : https://help.launchpad.net/ListHelp
