Paul Mackerras <[EMAIL PROTECTED]> writes: > Andreas Schwab writes: >> Paul Mackerras <[EMAIL PROTECTED]> writes: >> >> > Manish Ahuja writes: >> > >> >> Repost to fix my email id. >> >> >> >> Fix to correct a possible infinite loop or an always true check when the >> >> unsigned long counter "i" is used in >> >> lmb_add_region() in the following for loop: >> >> >> >> for (i = rgn->cnt-1; i >= 0; i--) >> > >> > Unfortunately this won't fix the bug. Since rgn->cnt is unsigned >> > long, the comparison will be done as an unsigned comparison even if i >> > is signed. >> >> ??? There is no rgn->cnt involved in the comparison. > > Look further down in lmb_add_region; there is a second for loop that > does > > for (i = rgn->cnt-1; i >= 0; i--)
Which is exactly the one quoted above. I still don't see your point. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
