On Tue, Jul 17, 2007 at 02:59:46AM +0200, Arnd Bergmann wrote:
> This is a step in the wrong direction. CPUINFO_{VENDOR,MACHINE}
> comes from a platform specific header file, so you can not
> use these definitions in platform independent code without
> breaking multiplatform kernels.My patchset just drops the vendor field, and uses ppc_md.name for the machine name. The vendor name can be included in the latter. > I know you're just moving that code, but it looks horribly wrong > nonetheless. cpm2_immr is an __iomem variable, so you must not > dereference it but instead should use the in_8() macro to > access it. > > Once you get that right, you don't need the volatile variable > any more. My patchset addresses this. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
