On Wednesday 18 July 2007, Scott Wood wrote:
> +static struct cpm_pin mpc8272ads_pins[] = {
> +       /* SCC1 */
> +       {3, 30, CPM_PIN_OUTPUT | CPM_PIN_SECONDARY},
> +       {3, 31, CPM_PIN_INPUT | CPM_PIN_PRIMARY},
> +
> +       /* SCC4 */
> +       {3, 21, CPM_PIN_OUTPUT | CPM_PIN_PRIMARY},
> +       {3, 22, CPM_PIN_INPUT | CPM_PIN_PRIMARY},
> +
> +       /* FCC1 */
> +       {0, 14, CPM_PIN_INPUT | CPM_PIN_PRIMARY},
> +       {0, 15, CPM_PIN_INPUT | CPM_PIN_PRIMARY},
> +       {0, 16, CPM_PIN_INPUT | CPM_PIN_PRIMARY},
> +       {0, 17, CPM_PIN_INPUT | CPM_PIN_PRIMARY},

I guess you considered moving such tables into the device tree at some point,
which doesn't seem that difficult at all to an ignorant reviewer like me.

What's the reasoning for putting it into the platform code after all?

        Arnd <><
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to