On Tue, 24 Jul 2007 08:37:09 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Andy Whitcroft wrote:
> > Andrew Morton wrote:
> >
> >>> + start_sector = req->sector*priv->blocking_factor;
> >>> + sectors = req->nr_sectors*priv->blocking_factor;
> >> s/*/ * /. checkpatch missed this.
> >
> > Ok, this is something we need to decide on. Currently we only ask for
> > consistent spacing on all the mathematic operators. This is mostly as
> > we do see a large number of non-spaced uses in defines and the like.
> >
> > I am happy to expand these tests so they are always spaced on both sides
> > style if that is the preference.
>
> That is most definitely the preference: spaces surround operators.
>
I must say that I find it hard to object to
start = radix_tree_next_hole(&mapping->page_tree, offset, max+1);
but when the expression is more complex the spaces help.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
