Arnd Bergmann wrote: > On Monday 30 July 2007, Dave Jiang wrote: >> Arnd Bergmann wrote: > >>> I'd suggest either to integrate EDAC into the 85xx specific PCI code, >>> or to have an extra device in the device tree for this. >> How about I create a platform device just for EDAC and leave the PCI >> of_device >> to the 85xx PCI code? That would be a lot less modification than adding a >> device for every PCI hose per DTS file.... Just a thought.... > > Hmm, I can see your point about not having to change all the device trees, > but if you really want to have a device for each of them, an of_device seems > more natural to me than a platform_device. > > What about the other option I mentioned, handling the EDAC stuff from the > fsl_add_bridge() function?
I'm not sure I follow your thought on this quite yet. Do you mean the setup of either of_device or platform_device or do you mean the actual pci err driver? I'm not understanding how doing the setup code in fsl_add_bridge() would allow us to prevent the of_device being monopolized by the EDAC driver or the future PCI code.... The EDAC driver still needs some sort of "device" to claim one way or another right? Of course I can go ahead and add the PCI err device in the DTS files for all 85xx if Kumar is okay with that idea.... -- ------------------------------------------------------ Dave Jiang Software Engineer MontaVista Software, Inc. http://www.mvista.com ------------------------------------------------------ _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev