On Thu, Sep 13, 2007 at 05:11:25PM +1000, David Gibson wrote: > > -#define immr_unmap(addr) iounmap(addr) > > +#define immr_map(member) (&mpc8xx_immr->member) > > +#define immr_map_size(member, size) (&mpc8xx_immr->member) > > +#define immr_unmap(addr) iounmap(addr) > > This looks bogus. You're replacing the old crap immr_map() functions, > which ioremap()ed the registers every time, with a much simpler > version which uses an established-once mapping of the register > region. AFAICT, anywah. > > So far, so good - but your immr_unmap() still does an iounmap() which > is surely wrong - it should now be a no-op, leaving the mpc8xx_immr > mapping intact. You probably get away with it by accident, because I > imagine attempting to unmap an unaligned chunk of the region will just > fail.
D'oh! Thanks for pointing that out. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev