On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: > On 10/8/07, Kumar Gala <[EMAIL PROTECTED]> wrote: >> >> On Oct 8, 2007, at 10:12 AM, Grant Likely wrote: >> >>> From: Grant Likely <[EMAIL PROTECTED]> >>> >>> I can't see a good reason for eval board platform code to mess with >>> the >>> ROOT_DEV value instead of using the default behaviour (so I'm >>> writing >>> this patch to see if anyone will clue me in). >>> >>> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> >>> --- >>> >>> arch/powerpc/platforms/52xx/efika.c | 9 --------- >>> arch/powerpc/platforms/52xx/lite5200.c | 12 ------------ >>> arch/powerpc/platforms/82xx/mpc82xx_ads.c | 6 ------ >>> arch/powerpc/platforms/8xx/mpc86xads_setup.c | 2 -- >>> arch/powerpc/platforms/8xx/mpc885ads_setup.c | 2 -- >>> arch/powerpc/platforms/chrp/setup.c | 10 ---------- >>> 6 files changed, 0 insertions(+), 41 deletions(-) >> >> FYI, 82xx_ads and 885ads don't have this issue in my tree based on >> fixes from Scott. > > So, if I respin this patch to exclude those two platforms, will you > merge it? (Efika and Lite5200 only have it because they were cloned > from CHRP. > > Powermac and pseries also do this weirdness. Should it be removed > from there too?
We need benh to make a comment about powermac. I think its ok to remove everywhere but we should see if he has any issue. - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev