Domen Puncer wrote: > On 26/10/07 07:18 -0700, Dale Farnsworth wrote: >> On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote: >>> +static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) >>> +{ >>> + struct net_device *dev = dev_id; >>> + struct mpc52xx_fec_priv *priv = netdev_priv(dev); >>> + >>> + spin_lock(&priv->lock); >>> + >>> + while (bcom_buffer_done(priv->tx_dmatsk)) { >>> + struct sk_buff *skb; >>> + struct bcom_fec_bd *bd; >>> + skb = bcom_retrieve_buffer(priv->tx_dmatsk, NULL, >>> + (struct bcom_bd **)&bd); >>> + /* Here (and in rx routines) would be a good place for >>> + * dma_unmap_single(), but bcom doesn't return bcom_bd of the >>> + * finished transfer, and _unmap is empty on this platfrom. >>> + */ >> Oops, you forgot to remove the above comment. :) > > Argh! > > Repost w/o the comment. > Sorry for receiving all this almost-spam. > > >> Otherwise, >> Acked-by: Dale Farnsworth <[EMAIL PROTECTED]> >> >> Domen, thanks for all your work on this. It's good to see it finally go in. >> >> -Dale > > --- again, use your scisors here ;-) --- > > > Driver for ethernet on mpc5200/mpc5200b SoCs (FEC). > > > Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> > Acked-by: Dale Farnsworth <[EMAIL PROTECTED]> > > --- > drivers/net/Kconfig | 24 > drivers/net/Makefile | 4 > drivers/net/fec_mpc52xx.c | 1112 > ++++++++++++++++++++++++++++++++++++++++++ > drivers/net/fec_mpc52xx.h | 313 +++++++++++ > drivers/net/fec_mpc52xx_phy.c | 198 +++++++ > 5 files changed, 1651 insertions(+)
applied to #upstream-fixes it's not strictly a fix, but I did not want to hold this back until 2.6.25 either _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev