On Mon, 5 Nov 2007 20:34:51 -0500 "Jon Smirl" <[EMAIL PROTECTED]> wrote:
>
> On 11/5/07, Scott Wood <[EMAIL PROTECTED]> wrote:
> > > +static struct of_platform_driver mpc_i2c_driver = {
> > > + .owner = THIS_MODULE,
> > > + .name = DRV_NAME,
> > > + .match_table = mpc_i2c_of_match,
> > > + .probe = mpc_i2c_probe,
> > > + .remove = __devexit_p(mpc_i2c_remove),
> > > + .driver = {
> > > + .name = DRV_NAME,
> > > },
> > > };
> >
> > Do we still need .name if we have .driver.name?
>
> This is a general question, if of_platform_driver doesn't need .name
> it should be removed from the structure.I am in the process of doing that. However there a quite a few drivers that need to be fixed first. In the meantime, of_register_platform_driver will copy which ever of the name and owner fields you fill in to the others, so we can convert over time. For new drivers (and changing), please use the name and owner fields in the embedded device_driver struct. (this is the same as done by the platform drivers currently ...) -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
pgpD6Eb0OCgP6.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
