> -----Original Message----- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Wednesday, November 21, 2007 11:32 AM > To: Li Yang > Cc: Paul Mackerras; linuxppc-dev@ozlabs.org; Grant Likely > Subject: Re: [PATCH v7 3/9] add Freescale SerDes PHY support > > > On Oct 19, 2007, at 10:35 AM, Grant Likely wrote: > > > On 10/19/07, Li Yang <[EMAIL PROTECTED]> wrote: > >> The SerDes(serializer/deserializer) PHY block is a new SoC > block used > >> in Freescale chips to support multiple serial interfaces, > such as PCI > >> Express, SGMII, SATA. > > > > This looks like board setup behaviour. Shouldn't setting > this up be > > the responsibility firmware? And failing that, I think it > should be > > done directly by the platform setup function (in other > words; make it > > a helper function and call it at board setup time). > Besides, you want > > to provide guarantees that the board is setup correctly before the > > device driver that uses it gets probed. > > > > Cheers, > > g. > > Upon further review of all this I don't think this belongs in > the kernel at all. This is one time setup and should be done > in firmware.
I'm ok for it to be taken care of in u-boot for now. However, if we later plan to add power management support to this block. We probably have to do it in kernel. - Leo _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
