On 13-04-16, 23:27, Akshay Adiga wrote:
> On 04/13/2016 10:33 AM, Viresh Kumar wrote:
> >>+void gpstate_timer_handler(unsigned long data)
> >>+{
> >>+ struct cpufreq_policy *policy = (struct cpufreq_policy *) data;
> >no need to cast.
>
> May be i need a cast here, because data is unsigned long ( unlike other
> places where its void *).
> On building without cast, it throws me a warning.
My bad, yeah :(
> >>+ if (freq_data.gpstate_id != freq_data.pstate_id)
> >>+ ret = queue_gpstate_timer(gpstates);
> >ret not used.
>
> Should i make it void instead of returning int?, as i cannot do much even if
> it fails, except for notifying.
Sure.
--
viresh
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
