On 04/14/2016 11:30 AM, Gavin Shan wrote:
On Thu, Apr 14, 2016 at 09:57:32AM +1000, Alistair Popple wrote:
Hi Gavin,
<snip>
Why exactly cannot EEH reset changes go to a smaller separate patchset
(before hotplug)?
As I explained before, the patchset's order is: PCI generic part,
PowerNV PCI related, EEH related, device-tree part and hotplug driver.
The EEH reset change is included in PATCH[37/45]. There is no point
to reorder the patches.
I don't understand all of the dependencies but if possible splitting the
series up into a set of smaller self-contained patch series makes things
easier to review and may make it easier for you to get this functionality
reviewed and accepted into upstream.
Thanks, Alistair. I will move those cleanup/refactor related patches
to form a separate series which is expected to be merged first. That
will helps the reviewers to focus on the patches with complicated
changes as you suggested. Alexey, please let me know if that way is
you like to see or not.
I do not know yet, I have not finished reviewing this version. May be the
EEH reset patch depends on 1/45..36/45; or it only makes sense when 45/45
is applied - this all is unclear.
If 37/45 has no dependencies and good just by itself, you could have posted
it separately few months ago and it would have reached upstream by now and
this patchset would be at least one patch shorter and you would not have to
rebase all 45 patches over and over again on top of the current upstream
tree...
--
Alexey
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
