I've sent v5 series for this. Please review it. Thanks, Ravi
On Wednesday 13 July 2016 03:15 PM, Ravi Bangoria wrote: > Arnaldo, Michael, > > I've tested this patchset on ppc64 BE and LE both. Please review this. > > -Ravi > > On Friday 08 July 2016 10:10 AM, Ravi Bangoria wrote: >> Perf can currently only support code navigation (branches and calls) in >> annotate when run on the same architecture where perf.data was recorded. >> But cross arch annotate is not supported. >> >> This patchset enables cross arch annotate. Currently I've used x86 >> and arm instructions which are already available and adding support >> for powerpc as well. Adding support for other arch will be easy. >> >> I've created this patch on top of acme/perf/core. And tested it with >> x86 and powerpc only. >> >> Note for arm: >> Few instructions were defined under #if __arm__ which I've used as a >> table for arm. But I'm not sure whether instruction defined outside of >> that also contains arm instructions. Apart from that, 'call__parse()' >> and 'move__parse()' contains #ifdef __arm__ directive. I've changed it >> to if (!strcmp(norm_arch, arm)). I don't have a arm machine to test >> these changes. >> >> Example: >> >> Record on powerpc: >> $ ./perf record -a >> >> Report -> Annotate on x86: >> $ ./perf report -i perf.data.powerpc --vmlinux vmlinux.powerpc >> >> Changes in v4: >> - powerpc: Added support for branch instructions that includes 'ctr' >> - __maybe_unused was misplaced at few location. Corrected it. >> - Moved position of v3 last patch that define macro for each arch name >> >> v3 link: https://lkml.org/lkml/2016/6/30/99 >> >> Naveen N. Rao (1): >> perf annotate: add powerpc support >> >> Ravi Bangoria (2): >> perf: Define macro for normalized arch names >> perf annotate: Enable cross arch annotate >> >> tools/perf/arch/common.c | 36 ++--- >> tools/perf/arch/common.h | 11 ++ >> tools/perf/builtin-top.c | 2 +- >> tools/perf/ui/browsers/annotate.c | 3 +- >> tools/perf/ui/gtk/annotate.c | 2 +- >> tools/perf/util/annotate.c | 273 >> ++++++++++++++++++++++++++++++------- >> tools/perf/util/annotate.h | 6 +- >> tools/perf/util/unwind-libunwind.c | 4 +- >> 8 files changed, 265 insertions(+), 72 deletions(-) >> >> -- >> 2.5.5 >> >
