On Thu, 10 Jan 2008 08:01:09 -0700 "Grant Likely" <[EMAIL PROTECTED]> wrote:
>
> On 1/10/08, Stephen Rothwell <[EMAIL PROTECTED]> wrote:
> > Hi Grant,
> >
> > On Wed, 09 Jan 2008 22:26:30 -0700 Grant Likely <[EMAIL PROTECTED]> wrote:
> > >
> > > +mpc52xx_map_common_devices(void)
> > > {
> >
> > > + /* Clock Distribution Module, used by PSC clock setting function */
> > > + np = of_find_matching_node(NULL, mpc52xx_cdm_ids);
> >
> > What happens if we find no node?
>
> Both of_iomap and of_put fail gracefully if np is NULL. IIRC that was
> done on purpose so this exact thing could be done.
>
> Users of mpc52xx_cdm (and the others done in this style) all check for
> mpc52xx_cdm being NULL before dereferencing.Excellent, thanks. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
pgppT1sZb0Jam.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
