On Jan 9, 2008, at 8:56 PM, David Gibson wrote:
> On Mon, Jan 07, 2008 at 09:25:29AM -0500, Paul Gortmaker wrote:
>> This adds the device tree source for the Wind River SBC8560 board.
>> The
>> biggest difference between this and the MPC8560ADS reference platform
>> dts is the use of an external 16550 compatible UART instead of the
>> CPM2.
>>
>> Signed-off-by: Paul Gortmaker <[EMAIL PROTECTED]>
>> ---
>> arch/powerpc/boot/dts/sbc8560.dts | 285 +++++++++++++++++++++++++++
>> ++++++++++
>
> [snip]
>> + [EMAIL PROTECTED] {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "localbus";
>
> This compatible doesn't look specific enough. It should at least have
> a vendor prefix.
>
>> + ranges = <0 fc000000 00c00000>;
>
> Typically, we've been doing these external bust controller type
> gadgets with address-cells = <2>, the first cell explicitly encoding
> the chipselect. This gets us closer to the ideal of the device tree
> encoding only hardware information, not how the bridge controller is
> configured (although "ranges" will still have to contain configuration
> dependent information).
>
>
>> +
>> + serial0: [EMAIL PROTECTED] {
>> + device_type = "serial";
>> + compatible = "ns16550";
>> + reg = <700000 100>;
>> + clock-frequency = <1C2000>;
>> + interrupts = <9 2>;
>> + interrupt-parent = <&mpic>;
>> + };
>> +
>> + serial1: [EMAIL PROTECTED] {
>> + device_type = "serial";
>> + compatible = "ns16550";
>> + reg = <800000 100>;
>> + clock-frequency = <1C2000>;
>> + interrupts = <a 2>;
>> + interrupt-parent = <&mpic>;
>> + };
>> +
>> + [EMAIL PROTECTED] {
>> + compatible = "m48t59";
>> + reg = <900000 2000>;
>> + };
>> + };
>> +};
Paul,
any updates here based on David's comments on how we are representing
localbus nodes?
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
