Hi Marian,

On Thu, 17 Jan 2008 19:09:17 +0100 Marian Balakowicz <[EMAIL PROTECTED]> wrote:
>
> +static int __devinit mpled_probe(struct of_device *op,
> +                              const struct of_device_id *match)
> +{
> +     struct motionpro_led *mpled;
> +     const unsigned int *of_blink_delay;
> +     const char *label;
> +     int err;
> +
> +     dev_dbg(&op->dev, "mpled_probe: node=%s (op=%p, match=%p)\n",
> +             op->node->name, op, match);
> +
> +     mpled = kzalloc(sizeof(*mpled), GFP_KERNEL);
> +     if (!mpled)
> +             return -ENOMEM;
> +
> +     mpled->gpt = of_iomap(op->node, 0);
> +     if (!mpled->gpt) {
> +             printk(KERN_ERR __FILE__ ": "
> +                     "Error mapping GPT registers for LED %s\n",
> +                     op->node->full_name);
> +             err = -EIO;
> +             goto err_free;
> +     }
> +
> +     /* initialize GPT for LED use */
> +     mpled_init_led(&mpled->gpt->mode);
> +
> +     spin_lock_init(&mpled->led_lock);
> +     mpled->mode = LED_MODE_KERNEL;
> +
> +     /* get LED label, used to register led classdev */
> +     label = of_get_property(op->node, "label", NULL);
> +     if (label == NULL) {
> +             printk(KERN_ERR __FILE__ ": "
> +                     "No label property provided for LED %s\n",
> +                     op->node->full_name);
> +             err = -EINVAL;
> +             goto err_free;

                goto err;

> +static struct of_device_id mpled_match[] = {

Make this const, please.

-- 
Cheers,
Stephen Rothwell                    [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/

Attachment: pgp6ZzAezIn6s.pgp
Description: PGP signature

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to