On Wed, Apr 12, 2017 at 4:52 PM, Michael Ellerman <m...@ellerman.id.au> wrote: > Rashmica Gupta <rashmic...@gmail.com> writes: > >> On 31/03/17 12:37, Oliver O'Halloran wrote: >>> On Book3s we have two PTE flags used to mark cache-inhibited mappings: >>> _PAGE_TOLERANT and _PAGE_NON_IDEMPOTENT. Currently the kernel page >>> table dumper only looks at the generic _PAGE_NO_CACHE which is >>> defined to be _PAGE_TOLERANT. This patch modifies the dumper so >>> both flags are shown in the dump. >>> >>> Cc: Rashmica Gupta <rashmic...@gmail.com> >>> Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> > >> Should we also add in _PAGE_SAO that is in Book3s? > > I don't think we ever expect to see it in the kernel page tables. But if > we did that would be "interesting". > > I've forgotten what the code does with unknown bits, does it already > print them in some way?
Currently it just traverses the list of known bits and prints out a message for each. Printing any unknown bits is probably a good idea. I'll send another patch to add that though and leave this one as-is. > If not we should either add that or add _PAGE_SAO and everything else > that could possibly ever be there. ok