Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode

[Jin, Yao]

On 4/19/2017 2:53 AM, Jiri Olsa wrote:

On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote:

SNIP

+static int hist_iter__branch_callback(struct hist_entry_iter *iter,
+                                     struct addr_location *al __maybe_unused,
+                                     bool single __maybe_unused,
+                                     void *arg)
+{
+       struct hist_entry *he = iter->he;
+       struct report *rep = arg;
+       struct branch_info *bi;
+
+       if (sort__mode == SORT_MODE__BRANCH) {

is this check necessary? the hist_iter__branch_callback
was set based on this check

jirka

Let me double check.

Thanks
Jin Yao