On Fri 11-08-17 15:00:47, Pasha Tatashin wrote: > Hi Michal, > > This suggestion won't work, because there are arches without memblock > support: tile, sh... > > So, I would still need to have: > > #ifdef CONFIG_MEMBLOCK in page_alloc, or define memblock_discard() stubs in > nobootmem headfile.
This is the standard way to do this. And it is usually preferred to proliferate ifdefs in the code. -- Michal Hocko SUSE Labs