Thanks, I realized that on the way home.. That's what I get for trying to finish something quickly before leaving.. :)
Steve > -----Original Message----- > From: Nathan Lynch [mailto:[EMAIL PROTECTED] > Sent: Thursday, January 31, 2008 9:56 PM > To: Stephen Neuendorffer > Cc: linuxppc-dev@ozlabs.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: Re: [PATCH] [POWERPC] Xilinx: hwicap driver > > Stephen Neuendorffer wrote: > > > > +static ssize_t > > +hwicap_read(struct file *file, char *buf, size_t count, loff_t *ppos) > > +{ > > + struct hwicap_drvdata *drvdata = file->private_data; > > + ssize_t bytes_to_read = 0; > > + u32 *kbuf; > > + u32 words; > > + u32 bytes_remaining; > > + int status; > > + > > + spin_lock(&hwicap_spinlock); > > + if (drvdata->is_accessing) > > + return -EBUSY; > > Need to unlock before returning (several places in this patch). > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
