Hi Michael, Michael Ellerman <m...@ellerman.id.au> writes:
> Shea Levy <s...@shealevy.com> writes: > >> Joe Perches <j...@perches.com> writes: >> >>> On Wed, 2018-03-28 at 16:36 -0400, Shea Levy wrote: >>>> Signed-off-by: Shea Levy <s...@shealevy.com> >>> >>> Most people seem to want some form of commit message >>> and not just your sign-off. >>> >> >> Ah, if the subject is insufficient I can add some more detail. > > Yeah please do. > > Seeing this patch in isolation, with no change log, I might think it's > safe for me to just apply it. > > But that would break the build because I don't have patch 1. > > So for starters you need to explain that part, eg something like: > > A previous patch in the series added a weak definition of > free_initrd_mem() in init/initramfs.c. > > The powerpc implementation is identical, so it can be removed allowing > the generic version to be used. > > > Then you could also tell me if you did/didn't build/boot test it. Thanks for the feedback, can you let me know if the recently posted v6 fits the bill? > > cheers Thanks, Shea
signature.asc
Description: PGP signature
