On Tuesday, July 3, 2018 8:50:41 AM CEST Pingfan Liu wrote:
> Clean up the referring to the code in commit 52cdbdd49853 ("driver core:
> correct device's shutdown order"). So later we can revert it safely.
>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
> Cc: Grygorii Strashko <grygorii.stras...@ti.com>
> Cc: Christoph Hellwig <h...@infradead.org>
> Cc: Bjorn Helgaas <helg...@kernel.org>
> Cc: Dave Young <dyo...@redhat.com>
> Cc: linux-...@vger.kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Pingfan Liu <kernelf...@gmail.com>
> ---
> drivers/base/core.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 684b994..db3deb8 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -127,13 +127,6 @@ static int device_reorder_to_tail(struct device *dev,
> void *not_used)
> {
> struct device_link *link;
>
> - /*
> - * Devices that have not been registered yet will be put to the ends
> - * of the lists during the registration, so skip them here.
> - */
> - if (device_is_registered(dev))
> - devices_kset_move_last(dev);
> -
> if (device_pm_initialized(dev))
> device_pm_move_last(dev);
You can't do this.
If you do it, that will break power management in some situations.
Thanks,
Rafael
