From: Krzysztof Kozlowski > Sent: 24 July 2018 12:12 ... > >> Not tested on hardware. > > > > Have you verified that the old and new functions give the > > same result for a few mac addresses? > > It is very easy to use the wrong bits in crc calculations > > or generate the output in the wrong bit order. > > I copied the original code and new one onto a different driver and run > this in a loop for thousands of data input (although not all possible > MAC combinations). The output was the same. I agree however that real > testing would be important.
Since CRC are linear you only need to check that each input bit generates the correct output. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)