On Wednesday 27 February 2008 02:58:28 pm Jarod Wilson wrote: > On Saturday 23 February 2008 06:24:17 am Stefan Richter wrote: > > The generation of incoming requests was filled in in wrong byte order on > > machines with big endian CPU. > > > > Signed-off-by: Stefan Richter <[EMAIL PROTECTED]> > > Cc: [EMAIL PROTECTED] > > Cc: linuxppc-dev@ozlabs.org > > --- > > > > This patch is a shot in the dark, based on a warning when building with > > C=1 CHECKFLAGS="-D__CHECK_ENDIAN__". Is it really a fix, or was the > > previous code accidentally correct? > > > > This needs to be tested on different big endian PCs, if possible with > > the Apple Uninorth FireWire controller and other types of controllers. > > One test which involves ohci->request_generation is simply with an SBP-2 > > device (harddisk, CD-ROM...). Does SBP-2 login etc. work? > > Works just fine with the Apple UniNorth controller in my powerbook in > cursory testing. Tested with multiple sbp2 hard disks, plugging and > unplugging, mounting and unmounting, etc. > > > If possible, also test whether the device remains accessible after > > forcing a bus reset, e.g. by "echo br short > firecontrol". You need > > the easy to build utility firecontrol and a libraw1394 with "juju" > > backend. See wiki.linux1394.org for directions. > > Forgot to check that it survived bus resets. Will try to double-check that > tonight.
Survives bus resets just fine, including with ongoing I/O from an sbp2 disk. -- Jarod Wilson [EMAIL PROTECTED] _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
