Nathan Fontenot <nf...@linux.vnet.ibm.com> writes: > On 10/02/2018 08:00 PM, Michael Ellerman wrote: >> Michael Bringmann <m...@linux.vnet.ibm.com> writes: >> >>> powerpc/drmem: Export many of the functions of DRMEM to parse >>> "ibm,dynamic-memory" and "ibm,dynamic-memory-v2" during hotplug >>> operations and for Post Migration events. >> >> This isn't a criticism of your patch, but I think the drmem.c code >> should be moved into platforms/pseries. >> >> That would then make most of it private to platforms/pseries and we >> wouldn't need to export things in arch/powerpc/include/asm. > > I don't have an issue with moving it to platform/pseries. I originally > put it in arch/powerpc/mm because the numa code also uses the drmem code.
Yeah, originally the NUMA code was only used on pseries so the distinction between NUMA and pseries-specific NUMA didn't exist. But these days we're getting more and more code that is really pseries (or PAPR) specific, so it might make sense to move it. I may be wrong, perhaps there isn't a clean split there, but it would be worth trying. cheers