Manish Ahuja writes: > If Mike and Paul are okay, then I will leave this bit as is and fix all > other issues and comments.
Well, part of the problem is the semantic dissonance caused by having a static variable called "global". Please change the name "phyp_dump_global" to "phyp_dump_vars" or something similar - that will only affect two lines of code and will reduce the ugliness a bit. Paul. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev