Re: [PATCH V2 3/10] KVM/MMU: Add last_level in the struct mmu_spte_page

[Paolo Bonzini]

On 02/02/19 02:38, lantianyu1...@gmail.com wrote:
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index ce770b446238..70cafd3f95ab 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -2918,6 +2918,9 @@ static int set_spte(struct kvm_vcpu *vcpu, u64 *sptep,
>  
>       if (level > PT_PAGE_TABLE_LEVEL)
>               spte |= PT_PAGE_SIZE_MASK;
> +
> +     sp->last_level = is_last_spte(spte, level);

sp->last_level is always true here.

Paolo

>       if (tdp_enabled)
>               spte |= kvm_x86_ops->get_mt_mask(vcpu, gfn,
>                       kvm_is_mmio_pfn(pfn));