On 2/19/19 11:23 AM, Nicholas Piggin wrote:
Aneesh Kumar K.V's on February 14, 2019 4:45 pm:
When updating page tables, we need to make sure we fill the page table
entry valid bit. We should be using page table populate interface for
updating the table entries. The page table 'set' interface allows
updating the raw value of page table entry. This can result in
updating the entry wrongly. Remove the 'set' interface so that we avoid
its future usage.
Removing a pointless indirection is fine by me, but I can't
figure out how this change could help to prevent entry being updated
incorrectly.
I guess my commit message is confusing. What I meant is this avoid the
usage of pgd/pud_set from other kernel code without updating the page
table entry valid bits. The idea is to make pgd_populate as the only
interface for update pgd entries.
-aneesh
