The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./sound/soc/fsl/eukrea-tlv320.c:121:3-9: ERROR: missing of_node_put; acquired a 
node pointer with refcount incremented on line 102, but without a correspo    
nding object release within this function.
./sound/soc/fsl/eukrea-tlv320.c:127:3-9: ERROR: missing of_node_put; acquired a 
node pointer with refcount incremented on line 102, but without a correspo    
nding object release within this function.

Signed-off-by: Wen Yang <wen.yan...@zte.com.cn>
Cc: Liam Girdwood <lgirdw...@gmail.com>
Cc: Mark Brown <broo...@kernel.org>
Cc: Jaroslav Kysela <pe...@perex.cz>
Cc: Takashi Iwai <ti...@suse.com>
Cc: alsa-de...@alsa-project.org
Cc: linux-ker...@vger.kernel.org
---
 sound/soc/fsl/eukrea-tlv320.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/fsl/eukrea-tlv320.c b/sound/soc/fsl/eukrea-tlv320.c
index 191426a..30a3d68 100644
--- a/sound/soc/fsl/eukrea-tlv320.c
+++ b/sound/soc/fsl/eukrea-tlv320.c
@@ -118,13 +118,13 @@ static int eukrea_tlv320_probe(struct platform_device 
*pdev)
                if (ret) {
                        dev_err(&pdev->dev,
                                "fsl,mux-int-port node missing or invalid.\n");
-                       return ret;
+                       goto err;
                }
                ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port);
                if (ret) {
                        dev_err(&pdev->dev,
                                "fsl,mux-ext-port node missing or invalid.\n");
-                       return ret;
+                       goto err;
                }
 
                /*
-- 
2.9.5

Reply via email to