The call to of_find_node_by_path returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/powerpc/platforms/powernv/opal.c:741:2-8: ERROR: missing of_node_put; 
acquired a node pointer with refcount incremented on line 733, but without a 
corresponding object release within this function.

Signed-off-by: Wen Yang <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Nicholas Piggin <[email protected]>
Cc: Mike Rapoport <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Mahesh Salgaonkar <[email protected]>
Cc: Haren Myneni <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
 arch/powerpc/platforms/powernv/opal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/powernv/opal.c 
b/arch/powerpc/platforms/powernv/opal.c
index 2b0eca1..d7736a5 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -738,6 +738,7 @@ static void opal_export_attrs(void)
        kobj = kobject_create_and_add("exports", opal_kobj);
        if (!kobj) {
                pr_warn("kobject_create_and_add() of exports failed\n");
+               of_node_put(np);
                return;
        }
 
-- 
2.9.5

Reply via email to