On 3/29/19 5:53 AM, Michael Ellerman wrote:
> Mahesh J Salgaonkar <mah...@linux.vnet.ibm.com> writes:
>> diff --git a/arch/powerpc/include/asm/mce.h b/arch/powerpc/include/asm/mce.h
>> index 8d0b1c24c636..314ed3f13d59 100644
>> --- a/arch/powerpc/include/asm/mce.h
>> +++ b/arch/powerpc/include/asm/mce.h
>> @@ -110,17 +110,18 @@ enum MCE_LinkErrorType {
>> };
>>
>> struct machine_check_event {
>> - enum MCE_Version version:8; /* 0x00 */
>> - uint8_t in_use; /* 0x01 */
>> - enum MCE_Severity severity:8; /* 0x02 */
>> - enum MCE_Initiator initiator:8; /* 0x03 */
>> - enum MCE_ErrorType error_type:8; /* 0x04 */
>> - enum MCE_Disposition disposition:8; /* 0x05 */
>> - uint16_t cpu; /* 0x06 */
>> - uint64_t gpr3; /* 0x08 */
>> - uint64_t srr0; /* 0x10 */
>> - uint64_t srr1; /* 0x18 */
>> - union { /* 0x20 */
>> + enum MCE_Version version:8;
>> + uint8_t in_use;
>> + enum MCE_Severity severity:8;
>> + enum MCE_Initiator initiator:8;
>> + enum MCE_ErrorType error_type:8;
>> + enum MCE_Disposition disposition:8;
>> + uint8_t sync_error;
>> + uint16_t cpu;
>> + uint64_t gpr3;
>> + uint64_t srr0;
>> + uint64_t srr1;
>
> Can you switch these to use kernel types while you're at it, ie. u8, u64 etc.
sure.
>
>> @@ -194,6 +195,7 @@ struct mce_error_info {
>> } u;
>> enum MCE_Severity severity:8;
>> enum MCE_Initiator initiator:8;
>> + uint8_t sync_error;
>
> u8 here but bool later?
Will make it bool everywhere.
Thanks,
-Mahesh.
