On Mon, 2019-05-20 at 08:57:53 UTC, Anju T Sudhakar wrote: > Currently init_imc_pmu() can be failed either because > an IMC unit with invalid domain(i.e an IMC node not > supported by the kernel) is attempted a pmu-registration > or something went wrong while registering a valid IMC unit. > In both the cases kernel provides a 'Registration failed' > error message. > > Example: > Log message, when trace-imc node is not supported by the kernel, and the > skiboot supports trace-imc node. > > So for kernel, trace-imc node is now an unknown domain. > > [ 1.731870] nest_phb5_imc performance monitor hardware support registered > [ 1.731944] nest_powerbus0_imc performance monitor hardware support > registered > [ 1.734458] thread_imc performance monitor hardware support registered > [ 1.734460] IMC Unknown Device type > [ 1.734462] IMC PMU (null) Register failed > [ 1.734558] nest_xlink0_imc performance monitor hardware support registered > [ 1.734614] nest_xlink1_imc performance monitor hardware support registered > [ 1.734670] nest_xlink2_imc performance monitor hardware support registered > [ 1.747043] Initialise system trusted keyrings > [ 1.747054] Key type blacklist registered > > > To avoid ambiguity on the error message, return for invalid domain > before attempting a pmu registration. > > Fixes: 8f95faaac56c1 (`powerpc/powernv: Detect and create IMC device`) > Reported-by: Pavaman Subramaniyam <pavsu...@in.ibm.com> > Signed-off-by: Anju T Sudhakar <a...@linux.vnet.ibm.com> > Reviewed-by: Madhavan Srinivasan <ma...@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/b59bd3527fe3c1939340df558d7f9d56 cheers