On 12/08/19 3:12 PM, Mahesh J Salgaonkar wrote:
> On 2019-07-16 17:02:30 Tue, Hari Bathini wrote:
>> Introduce callback functions for platform specific operations like
>> register, unregister, invalidate & such. Also, define place-holders
>> for the same on pSeries platform.
>>
>> Signed-off-by: Hari Bathini <hbath...@linux.ibm.com>
>> ---
>> arch/powerpc/kernel/fadump-common.h | 33 ++++++
>> arch/powerpc/kernel/fadump.c | 47 +--------
>> arch/powerpc/platforms/pseries/Makefile | 1
>> arch/powerpc/platforms/pseries/rtas-fadump.c | 134
>> ++++++++++++++++++++++++++
>> 4 files changed, 171 insertions(+), 44 deletions(-)
>> create mode 100644 arch/powerpc/platforms/pseries/rtas-fadump.c
>>
>> diff --git a/arch/powerpc/kernel/fadump-common.h
>> b/arch/powerpc/kernel/fadump-common.h
>> index 09d6161..020d582 100644
>> --- a/arch/powerpc/kernel/fadump-common.h
>> +++ b/arch/powerpc/kernel/fadump-common.h
>> @@ -50,6 +50,12 @@
>> #define FADUMP_UNREGISTER 2
>> #define FADUMP_INVALIDATE 3
>>
>> +/* Firmware-Assited Dump platforms */
>> +enum fadump_platform_type {
>> + FADUMP_PLATFORM_UNKNOWN = 0,
>> + FADUMP_PLATFORM_PSERIES,
>> +};
>
> Do we really need these ? Aren't we hiding all platform specific things
> under fadump_ops functions ? I see that these values are used only for
> assignements and not making any decision in code flow. Am I missing
> anything here ?
True. This isn't really useful. will drop it..
Thanks
Hari
