> -----Original Message----- > From: Andrew Murray <andrew.mur...@arm.com> > Sent: 2019年9月2日 20:55 > To: Xiaowei Bao <xiaowei....@nxp.com> > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; Leo > Li <leoyang...@nxp.com>; kis...@ti.com; lorenzo.pieral...@arm.com; M.h. > Lian <minghuan.l...@nxp.com>; Mingkai Hu <mingkai...@nxp.com>; Roy > Zang <roy.z...@nxp.com>; jingooh...@gmail.com; > gustavo.pimen...@synopsys.com; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linuxppc-dev@lists.ozlabs.org; > a...@arndb.de; gre...@linuxfoundation.org; Z.q. Hou > <zhiqiang....@nxp.com> > Subject: Re: [PATCH v3 11/11] misc: pci_endpoint_test: Add LS1088a in > pci_device_id table > > On Mon, Sep 02, 2019 at 11:17:16AM +0800, Xiaowei Bao wrote: > > Add LS1088a in pci_device_id table so that pci-epf-test can be used > > for testing PCIe EP in LS1088a. > > > > Signed-off-by: Xiaowei Bao <xiaowei....@nxp.com> > > --- > > v2: > > - No change. > > v3: > > - No change. > > > > drivers/misc/pci_endpoint_test.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/misc/pci_endpoint_test.c > > b/drivers/misc/pci_endpoint_test.c > > index 6e208a0..d531951 100644 > > --- a/drivers/misc/pci_endpoint_test.c > > +++ b/drivers/misc/pci_endpoint_test.c > > @@ -793,6 +793,7 @@ static const struct pci_device_id > pci_endpoint_test_tbl[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) }, > > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) }, > > { PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) }, > > + { PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x80c0) }, > > The Freescale PCI devices are the only devices in this table that don't have a > define for their device ID. I think a define should be created for both of the > device IDs above.
OK, but I only define in this file, I am not sure this can define in include/linux/pci_ids.h file Thanks Xiaowei > > Thanks, > > Andrew Murray > > > { PCI_DEVICE_DATA(SYNOPSYS, EDDA, NULL) }, > > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_AM654), > > .driver_data = (kernel_ulong_t)&am654_data > > -- > > 2.9.5 > >