Hi all, After merging the powerpc tree, today's linux-next build (powerpc64 allnoconfig) failed like this:
arch/powerpc/mm/book3s64/pgtable.c: In function 'flush_partition':
arch/powerpc/mm/book3s64/pgtable.c:216:3: error: implicit declaration of
function 'radix__flush_all_lpid_guest'; did you mean 'radix__flush_all_lpid'?
[-Werror=implicit-function-declaration]
216 | radix__flush_all_lpid_guest(lpid);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| radix__flush_all_lpid
Caused by commit
99161de3a283 ("powerpc/64s/radix: tidy up TLB flushing code")
radix__flush_all_lpid_guest() is only declared for CONFIG_PPC_RADIX_MMU
which is not set for this build.
I am not sure why this did not show up earlier (maybe a Kconfig
change?).
I added the following hack for today.
From: Stephen Rothwell <s...@canb.auug.org.au>
Date: Mon, 30 Sep 2019 10:09:17 +1000
Subject: [PATCH] powerpc/64s/radix: fix for "tidy up TLB flushing code" and
!CONFIG_PPC_RADIX_MMU
Signed-off-by: Stephen Rothwell <s...@canb.auug.org.au>
---
arch/powerpc/include/asm/book3s/64/tlbflush-radix.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h
b/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h
index 4ce795d30377..ca8db193ae38 100644
--- a/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h
+++ b/arch/powerpc/include/asm/book3s/64/tlbflush-radix.h
@@ -35,6 +35,10 @@ static inline void radix__flush_all_lpid(unsigned int lpid)
{
WARN_ON(1);
}
+static inline void radix__flush_all_lpid_guest(unsigned int lpid)
+{
+ WARN_ON(1);
+}
#endif
extern void radix__flush_hugetlb_tlb_range(struct vm_area_struct *vma,
--
2.23.0.rc1
--
Cheers,
Stephen Rothwell
pgp77VNowbyID.pgp
Description: OpenPGP digital signature
