On 18/10/2019 18.08, Christoph Hellwig wrote: > On Fri, Oct 18, 2019 at 02:52:31PM +0200, Rasmus Villemoes wrote: >> /* wait for the QE_CR_FLG to clear */ >> - ret = spin_event_timeout((ioread32be(&qe_immr->cp.cecr) & QE_CR_FLG) == >> 0, >> - 100, 0); >> - /* On timeout (e.g. failure), the expression will be false (ret == 0), >> - otherwise it will be true (ret == 1). */ >> + ret = readx_poll_timeout_atomic(ioread32be, &qe_immr->cp.cecr, val, >> (val & QE_CR_FLG) == 0, > > This creates an overly long line.
Yeah, readx_poll_timeout_atomic is a mouthful, and then one also has to put in the name of the accessor... I'll wrap it when I respin the series, thanks. > Btw, given how few users of spin_event_timeout we have it might be good > idea to just kill it entirely. Maybe. That's for the ppc folks to comment on; the iopoll.h helpers are not completely equivalent (because obviously they don't read tbl directly). Maybe the generic versions should be taught spin_begin/spin_end/spin_cpu_relax so at least that part would be drop-in replacement. Rasmus
