On 04/11/2019 21.56, Li Yang wrote: >> No, this patch cannot be dropped. Please see the kbuild complaints for >> v2,23/23 about use of IS_ERR_VALUE on not-sizeof(long) entities. I see >> kbuild has complained about the same thing for v3 since apparently the >> same thing appears in ucc_slow.c. So I'll fix that. > > When I made this comment I didn't notice you have removed all the > architectural dependencies for CONFIG_QUICC_ENGINE. If the > QUICC_ENGINE is only buidable on powerpc, arm and arm64, this change > will not be needed. > > BTW, I'm not sure if it is a good idea to make it selectable on these > unrelavent architectures. Real architectural dependencies and > COMPILE_TEST dependency will be better if we really want to test the > buildability on other platforms.
Well, making QUICC_ENGINE depend on PPC32 || ARM would certainly make things easier for me. Once you include ARM64 or any other 64 bit architecture the buildbot complaints start rolling in from the IS_ERR_VALUEs. And ARM64 should be supported as well, so there really isn't much difference between dropping all arch restrictions and listing the relevant archs in the Kconfig dependencies. Rasmus