On 20/11/2019 12:28, Oliver O'Halloran wrote: > eeh_add_device_early() is used to initialise the EEH state for a PCI device > based on the contents of it's devicetree node. It doesn't do anything > unless EEH_FLAG_PROBE_MODE_DEVTREE is set and that only happens on pseries. > > Remove the call to eeh_add_device_early() in the powernv code to squash > another pci_dn usage. > > Signed-off-by: Oliver O'Halloran <ooh...@gmail.com> Reviewed-by: Alexey Kardashevskiy <a...@ozlabs.ru> > --- > arch/powerpc/platforms/powernv/eeh-powernv.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c > b/arch/powerpc/platforms/powernv/eeh-powernv.c > index 5250c4525544..aa2935a08464 100644 > --- a/arch/powerpc/platforms/powernv/eeh-powernv.c > +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c > @@ -40,13 +40,10 @@ static int eeh_event_irq = -EINVAL; > > void pnv_pcibios_bus_add_device(struct pci_dev *pdev) > { > - struct pci_dn *pdn = pci_get_pdn(pdev); > - > - if (!pdn || eeh_has_flag(EEH_FORCE_DISABLED)) > + if (eeh_has_flag(EEH_FORCE_DISABLED)) > return; > > dev_dbg(&pdev->dev, "EEH: Setting up device\n"); > - eeh_add_device_early(pdn); > eeh_add_device_late(pdev); > } > > -- Alexey
- Re: [Very RFC 08/46] powerpc/eeh: Calculate VF i... Alexey Kardashevskiy
- [Very RFC 09/46] powerpc/eeh: Pass eeh_dev to eeh_ops... Oliver O'Halloran
- Re: [Very RFC 09/46] powerpc/eeh: Pass eeh_dev t... Alexey Kardashevskiy
- [Very RFC 10/46] powerpc/eeh: Pass eeh_dev to eeh_ops... Oliver O'Halloran
- [Very RFC 11/46] powerpc/eeh: Convert various printfs... Oliver O'Halloran
- Re: [Very RFC 11/46] powerpc/eeh: Convert variou... Alexey Kardashevskiy
- [Very RFC 12/46] powerpc/eeh: Split eeh_probe into pr... Oliver O'Halloran
- Re: [Very RFC 12/46] powerpc/eeh: Split eeh_prob... Alexey Kardashevskiy
- [Very RFC 13/46] powerpc/eeh: Rework how pdev_probe()... Oliver O'Halloran
- [Very RFC 14/46] powernv/eeh: Remove un-necessary cal... Oliver O'Halloran
- Re: [Very RFC 14/46] powernv/eeh: Remove un-nece... Alexey Kardashevskiy
- [Very RFC 15/46] powernv/eeh: Use pnv_eeh_*_config() ... Oliver O'Halloran
- Re: [Very RFC 15/46] powernv/eeh: Use pnv_eeh_*_... Alexey Kardashevskiy
- [Very RFC 16/46] powernv/eeh: Use eeh_edev_warn() rat... Oliver O'Halloran
- Re: [Very RFC 16/46] powernv/eeh: Use eeh_edev_w... Alexey Kardashevskiy
- [Very RFC 17/46] powernv/eeh: add pnv_eeh_find_edev() Oliver O'Halloran
- Re: [Very RFC 17/46] powernv/eeh: add pnv_eeh_fi... Alexey Kardashevskiy
- [Very RFC 18/46] powernv/pci: Add pci_bus_to_pnvhb() ... Oliver O'Halloran
- Re: [Very RFC 18/46] powernv/pci: Add pci_bus_to... Alexey Kardashevskiy
- [Very RFC 19/46] powernv/eeh: Use standard PCI capabi... Oliver O'Halloran
- Re: [Very RFC 19/46] powernv/eeh: Use standard P... Alexey Kardashevskiy