> -----Original Message-----
> From: Rasmus Villemoes <[email protected]>
> Sent: Thursday, November 28, 2019 8:56 AM
> To: Qiang Zhao <[email protected]>; Leo Li <[email protected]>;
> Christophe Leroy <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Scott Wood <[email protected]>; Timur Tabi
> <[email protected]>; Rasmus Villemoes <[email protected]>;
> [email protected]
> Subject: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of
> IS_ERR_VALUE()

Hi David,

Would you help to review patch 44-47 in the series?  If it is fine with you, I 
can take these 4 patches with the whole series though soc tree to enable the QE 
drivers on ARM and PPC64 with your ACK.

Thanks,
Leo

> 
> When building this on a 64-bit platform gcc rightly warns that the error
> checking is broken (-ENOMEM stored in an u32 does not compare greater
> than (unsigned long)-MAX_ERRNO). Instead, now that
> qe_muram_alloc() returns s32, use that type to store the return value and
> use standard kernel style "ret < 0".
> 
> Reviewed-by: Timur Tabi <[email protected]>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Reply via email to