Juergen Beisert wrote:
On Thursday 17 April 2008 17:10, Matt Sealey wrote:
Juergen Beisert wrote:
Hi,
+       /* the fifo starts right after psc ends */
+       priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */
Wouldn't

        priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(struct
mpc52xx_psc));

Be a little less obtuse use of C?

"priv->psc" is of type "struct mpc52xx_ac97_priv*". If I add 0x58 to it, wouldn't I add 0x58 times the size of "struct mpc52xx_ac97_priv"?

I always got a result of MBAR+PSC_OFFSET(n)+0x58 out of it as I expected.

priv->psc is of type struct mpc52xx_psc * which means it's just pointer
arithmetic. If you add a value to it (not increment or so as if it's
an array) then it just adds the value, no?

--
Matt Sealey <[EMAIL PROTECTED]>
Genesi, Manager, Developer Relations
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to