On Wed, Mar 11, 2020 at 06:08:15PM -0500, Scott Cheloha wrote: > At memory hot-remove time we can retrieve an LMB's nid from its > corresponding memory_block. There is no need to store the nid > in multiple locations. > > Signed-off-by: Scott Cheloha <chel...@linux.ibm.com> > --- > The linear search in powerpc's memory_add_physaddr_to_nid() has become a > bottleneck at boot on systems with many LMBs. > > As described in this patch here: > > https://lore.kernel.org/linuxppc-dev/20200221172901.1596249-2-chel...@linux.ibm.com/ > > the linear search seriously cripples drmem_init(). > > The obvious solution (shown in that patch) is to just make the search > in memory_add_physaddr_to_nid() faster. An XArray seems well-suited > to the task of mapping an address range to an LMB object. > > The less obvious approach is to just call memory_add_physaddr_to_nid() > in fewer places. > > I'm not sure which approach is correct, hence the RFC.
You basically revert the below which will likely cause the very error that was fixed there: commit b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 Author: Nathan Fontenot <nf...@linux.vnet.ibm.com> Date: Tue Oct 2 10:35:59 2018 -0500 powerpc/pseries: Track LMB nid instead of using device tree When removing memory we need to remove the memory from the node it was added to instead of looking up the node it should be in in the device tree. During testing we have seen scenarios where the affinity for a LMB changes due to a partition migration or PRRN event. In these cases the node the LMB exists in may not match the node the device tree indicates it belongs in. This can lead to a system crash when trying to DLPAR remove the LMB after a migration or PRRN event. The current code looks up the node in the device tree to remove the LMB from, the crash occurs when we try to offline this node and it does not have any data, i.e. node_data[nid] == NULL. Thanks Michal