On Fri, Mar 27, 2020 at 03:55:25PM +0530, Kajol Jain wrote:
SNIP
> + eg->ids = ids;
> + eg->idnum = idnum;
> + eg->metric_name = pe->metric_name;
> + eg->metric_expr = pe->metric_expr;
> + eg->metric_unit = pe->unit;
> + list_add_tail(&eg->nd, group_list);
> +
> + return 0;
> +}
> +
> static int metricgroup__add_metric(const char *metric, struct strbuf *events,
> struct list_head *group_list)
> {
> @@ -504,35 +538,12 @@ static int metricgroup__add_metric(const char *metric,
> struct strbuf *events,
> continue;
> if (match_metric(pe->metric_group, metric) ||
> match_metric(pe->metric_name, metric)) {
> - const char **ids;
> - int idnum;
> - struct egroup *eg;
>
> pr_debug("metric expr %s for %s\n", pe->metric_expr,
> pe->metric_name);
>
> - if (expr__find_other(pe->metric_expr,
> - NULL, &ids, &idnum) < 0)
> + ret = __metricgroup__add_metric(events, group_list, pe);
> + if (ret == -EINVAL || !ret)
> continue;
what's the point of continue in here? it's end of the loop..
jirka
