> -----Original Message----- > From: Dan Williams <dan.j.willi...@intel.com> > Sent: Wednesday, 1 April 2020 7:49 PM > To: Alastair D'Silva <alast...@d-silva.org> > Cc: Aneesh Kumar K . V <aneesh.ku...@linux.ibm.com>; Oliver O'Halloran > <ooh...@gmail.com>; Benjamin Herrenschmidt > <b...@kernel.crashing.org>; Paul Mackerras <pau...@samba.org>; Michael > Ellerman <m...@ellerman.id.au>; Frederic Barrat <fbar...@linux.ibm.com>; > Andrew Donnellan <a...@linux.ibm.com>; Arnd Bergmann > <a...@arndb.de>; Greg Kroah-Hartman <gre...@linuxfoundation.org>; > Vishal Verma <vishal.l.ve...@intel.com>; Dave Jiang > <dave.ji...@intel.com>; Ira Weiny <ira.we...@intel.com>; Andrew Morton > <a...@linux-foundation.org>; Mauro Carvalho Chehab > <mchehab+sams...@kernel.org>; David S. Miller <da...@davemloft.net>; > Rob Herring <r...@kernel.org>; Anton Blanchard <an...@ozlabs.org>; > Krzysztof Kozlowski <k...@kernel.org>; Mahesh Salgaonkar > <mah...@linux.vnet.ibm.com>; Madhavan Srinivasan > <ma...@linux.vnet.ibm.com>; Cédric Le Goater <c...@kaod.org>; Anju T > Sudhakar <a...@linux.vnet.ibm.com>; Hari Bathini > <hbath...@linux.ibm.com>; Thomas Gleixner <t...@linutronix.de>; Greg > Kurz <gr...@kaod.org>; Nicholas Piggin <npig...@gmail.com>; Masahiro > Yamada <yamada.masah...@socionext.com>; Alexey Kardashevskiy > <a...@ozlabs.ru>; Linux Kernel Mailing List <linux-ker...@vger.kernel.org>; > linuxppc-dev <linuxppc-dev@lists.ozlabs.org>; linux-nvdimm <linux- > nvd...@lists.01.org>; Linux MM <linux...@kvack.org> > Subject: Re: [PATCH v4 08/25] ocxl: Emit a log message showing how much > LPC memory was detected > > On Sun, Mar 29, 2020 at 10:23 PM Alastair D'Silva <alast...@d-silva.org> > wrote: > > > > This patch emits a message showing how much LPC memory & special > > purpose memory was detected on an OCXL device. > > > > Signed-off-by: Alastair D'Silva <alast...@d-silva.org> > > Acked-by: Frederic Barrat <fbar...@linux.ibm.com> > > Acked-by: Andrew Donnellan <a...@linux.ibm.com> > > --- > > drivers/misc/ocxl/config.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > > index a62e3d7db2bf..69cca341d446 100644 > > --- a/drivers/misc/ocxl/config.c > > +++ b/drivers/misc/ocxl/config.c > > @@ -568,6 +568,10 @@ static int read_afu_lpc_memory_info(struct > pci_dev *dev, > > afu->special_purpose_mem_size = > > total_mem_size - lpc_mem_size; > > } > > + > > + dev_info(&dev->dev, "Probed LPC memory of %#llx bytes and special > purpose memory of %#llx bytes\n", > > + afu->lpc_mem_size, afu->special_purpose_mem_size); > > A patch for a single log message is too fine grained for my taste, let's > squash > this into another patch in the series. >
I'm not sure there's a great place for it. At a pinch, it could with the previous patch, but they are really different layers. > > + > > return 0; > > } > > > > -- > > 2.24.1 > > > > > -- > This email has been checked for viruses by AVG. > https://www.avg.com