On Tue, Dec 10, 2019 at 12:35:14AM -0500, George Spelvin wrote: > ... in boot_init_stack_canary(). > > This is the archetypical example of where the extra security of > get_random_bytes() is wasted. The canary is only important as > long as it's stored in __stack_chk_guard. > > It's also a great example of code that has been copied around > a lot and not updated. > > Remove the XOR with LINUX_VERSION_CODE as it's pointless; the inclusion > of utsname() in init_std_data in the random seeding obviates it. > > The XOR with the TSC on x86 and mtfb() on powerPC were left in, > as I haven't proved them redundant yet. For those, we call > get_random_long(), xor, and mask manually. > > FUNCTIONAL CHANGE: mips and xtensa were changed from 64-bit > get_random_long() to 56-bit get_random_canary() to match the > others, in accordance with the logic in CANARY_MASK. > > (We could do 1 bit better and zero *one* of the two high bytes.) > > Signed-off-by: George Spelvin <[email protected]> > Cc: Russell King <[email protected]> > Cc: [email protected] > Cc: Catalin Marinas <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Ralf Baechle <[email protected]> > Cc: Paul Burton <[email protected]> > Cc: James Hogan <[email protected]> > Cc: [email protected] > Cc: Benjamin Herrenschmidt <[email protected]> > Cc: Paul Mackerras <[email protected]> > Cc: Michael Ellerman <[email protected]> > Cc: [email protected] > Cc: Yoshinori Sato <[email protected]> > Cc: Rich Felker <[email protected]> > Cc: [email protected] > Cc: Thomas Gleixner <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: "H. Peter Anvin" <[email protected]> > Cc: [email protected] > Cc: Chris Zankel <[email protected]> > Cc: Max Filippov <[email protected]> > Cc: [email protected] > --- > arch/arm/include/asm/stackprotector.h | 9 +++------ > arch/arm64/include/asm/stackprotector.h | 8 ++------ > arch/mips/include/asm/stackprotector.h | 7 ++----- > arch/powerpc/include/asm/stackprotector.h | 6 ++---- > arch/sh/include/asm/stackprotector.h | 8 ++------ > arch/x86/include/asm/stackprotector.h | 4 ++-- > arch/xtensa/include/asm/stackprotector.h | 7 ++----- > 7 files changed, 15 insertions(+), 34 deletions(-)
Just found this kicking around in the depths of my inbox. Is the series dead? Will
