Jiri Kosina <ji...@kernel.org> writes: > On Mon, 18 May 2020, Jiri Kosina wrote: >> > > Include linux/io.h into fsl_85xx_cache_sram.c to fix the >> > > implicit-declaration compile errors when building Cache-Sram. >> > > >> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function >> > > ‘instantiate_cache_sram’: >> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit >> > > declaration >> > > of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? >> > > [-Werror=implicit-function-declaration] >> > > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys, >> > > ^~~~~~~~~~~~~~~~ >> > > bitmap_complement >> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes >> > > pointer from integer without a cast [-Werror=int-conversion] >> > > cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys, >> > > ^ >> > > arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit >> > > declaration >> > > of function ‘iounmap’; did you mean ‘roundup’? >> > > [-Werror=implicit-function-declaration] >> > > iounmap(cache_sram->base_virt); >> > > ^~~~~~~ >> > > roundup >> > > cc1: all warnings being treated as errors >> > > >> > > Fixed: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support") >> > > Signed-off-by: WANG Wenhu <wenhu.w...@vivo.com> >> > >> > Reviewed-by: Christophe Leroy <christophe.le...@c-s.fr> >> >> As this doesn't seem to have been picked up for linux-next yet, I am >> picking it up now. > > Only now I've noticed that this is actually a dead code o_O as this file > can't be built by any combination of config options. So I am dropping the > patch again, but why do we keep it in the tree in the first place?
Yeah, sigh. As Christophe pointed out, it has been dead code for a long time but there is a series in flight that's trying to make it usable. cheers