On 02/07/2020 10:36, Leonardo Bras wrote: > On Thu, 2020-07-02 at 10:21 +1000, Alexey Kardashevskiy wrote: >>> enum { >>> DDW_QUERY_PE_DMA_WIN, >>> DDW_CREATE_PE_DMA_WIN, >>> DDW_REMOVE_PE_DMA_WIN, >>> >>> DDW_APPLICABLE_SIZE >>> } >>> IMO, it looks better than all the defines before. >>> >>> What do you think? >> >> No, not really, these come from a binary interface so the reader of this >> cares about absolute numbers and rather wants to see them explicitly. > > Makes sense to me. > I am still getting experience on where to use enum vs define. Thanks > for the tip! > > Using something like > enum { > DDW_QUERY_PE_DMA_WIN = 0, > DDW_CREATE_PE_DMA_WIN = 1, > DDW_REMOVE_PE_DMA_WIN = 2, > > DDW_APPLICABLE_SIZE > }; > > would be fine too? This is fine too. > Or should one stick to #define in this case? imho a matter of taste but after some grepping it feels like #define is mostly used which does not mean it is a good idea. Keep it enum and see if it passed mpe's filter :) -- Alexey
- [PATCH v2 0/6] Remove default DMA window before creat... Leonardo Bras
- [PATCH v2 1/6] powerpc/pseries/iommu: Create def... Leonardo Bras
- Re: [PATCH v2 1/6] powerpc/pseries/iommu: Cr... Alexey Kardashevskiy
- Re: [PATCH v2 1/6] powerpc/pseries/iommu... Leonardo Bras
- Re: [PATCH v2 1/6] powerpc/pseries/i... Alexey Kardashevskiy
- Re: [PATCH v2 1/6] powerpc/pser... Leonardo Bras
- Re: [PATCH v2 1/6] powerpc/... Alexey Kardashevskiy
- Re: [PATCH v2 1/6] powe... Leonardo Bras
- [PATCH v2 2/6] powerpc/pseries/iommu: Update cal... Leonardo Bras
- Re: [PATCH v2 2/6] powerpc/pseries/iommu: Up... Alexey Kardashevskiy
- Re: [PATCH v2 2/6] powerpc/pseries/iommu... Leonardo Bras
- Re: [PATCH v2 2/6] powerpc/pseries/i... Alexey Kardashevskiy
- Re: [PATCH v2 2/6] powerpc/pser... Leonardo Bras
- [PATCH v2 3/6] powerpc/pseries/iommu: Move windo... Leonardo Bras
- [PATCH v2 4/6] powerpc/pseries/iommu: Remove def... Leonardo Bras
- Re: [PATCH v2 4/6] powerpc/pseries/iommu: Re... Alexey Kardashevskiy
- Re: [PATCH v2 4/6] powerpc/pseries/iommu... Leonardo Bras