Re: [PATCH v3 06/12] ppc64/kexec_file: restrict memory usage of kdump kernel

[Hari Bathini]

On 17/07/20 3:33 am, Thiago Jung Bauermann wrote:
> 
> Hari Bathini <hbath...@linux.ibm.com> writes:
> 
>> On 16/07/20 4:22 am, Thiago Jung Bauermann wrote:
>>>
>>> Hari Bathini <hbath...@linux.ibm.com> writes:
>>>

<snip>
 
>>>> +   * each representing a memory range.
>>>> +   */
>>>> +  ranges = (len >> 2) / (n_mem_addr_cells + n_mem_size_cells);
>>>> +
>>>> +  for (i = 0; i < ranges; i++) {
>>>> +          base = of_read_number(prop, n_mem_addr_cells);
>>>> +          prop += n_mem_addr_cells;
>>>> +          end = base + of_read_number(prop, n_mem_size_cells) - 1;
>>
>> prop is not used after the above.
>>
>>> You need to `prop += n_mem_size_cells` here.
>>
>> But yeah, adding it would make it look complete in some sense..
> 
> Isn't it used in the next iteration of the loop?

Memory@XXX/reg typically has only one range. I was looking at it
from that perspective which is not right. Will update.

Thanks
Hari