* Jordan Niethe <[email protected]> [2020-07-20 17:47:27]: > On Tue, Jul 14, 2020 at 2:44 PM Srikar Dronamraju > <[email protected]> wrote: > > > > Enable small core scheduling as soon as we detect that we are in a > > system that supports thread group. Doing so would avoid a redundant > > check. > > > > Cc: linuxppc-dev <[email protected]> > > Cc: Michael Ellerman <[email protected]> > > Cc: Nick Piggin <[email protected]> > > Cc: Oliver OHalloran <[email protected]> > > Cc: Nathan Lynch <[email protected]> > > Cc: Michael Neuling <[email protected]> > > Cc: Anton Blanchard <[email protected]> > > Cc: Gautham R Shenoy <[email protected]> > > Cc: Vaidyanathan Srinivasan <[email protected]> > > Signed-off-by: Srikar Dronamraju <[email protected]> > > --- > > arch/powerpc/kernel/smp.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > > index 24529f6134aa..7d430fc536cc 100644 > > --- a/arch/powerpc/kernel/smp.c > > +++ b/arch/powerpc/kernel/smp.c > > @@ -892,6 +892,12 @@ static int init_big_cores(void) > > } > > > > has_big_cores = true; > > + > > +#ifdef CONFIG_SCHED_SMT > > + pr_info("Big cores detected. Using small core scheduling\n"); > Why change the wording from "Big cores detected but using small core > scheduling\n"? > > + powerpc_topology[0].mask = smallcore_smt_mask; > > +#endif > > +
To me, "but" in the message sounded as if we detected Big cores *but* we want to continue using smallcore scheduling. However the code was always meaning to say, "Since we detected big core, i.e thread grouping within a core, System would benefit by using small core scheduling". If you think, "but" was adding more info and not misleading, then I can add it back. > > return 0; > > } > > -- Thanks and Regards Srikar Dronamraju
